Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PullRequests *to* forked repo from the forked repo branch should be treated as normal PullRequest #603

Closed
haya14busa opened this issue May 24, 2020 · 0 comments · Fixed by #653
Closed

PullRequests *to* forked repo from the forked repo branch should be treated as normal PullRequest #603

haya14busa opened this issue May 24, 2020 · 0 comments · Fixed by #653
Labels
good first issue

Comments

@haya14busa
Copy link
Member

Filed from reviewdog/action-shellcheck#9

isPRFromForkedRepo should return false.
@haya14busa haya14busa mentioned this issue May 24, 2020
Closed
haya14busa added a commit that referenced this issue Jun 29, 2020
@haya14busa
Fix detection logic to determin Pull Requests from forked repo
e9122dc 
Head and base repos can be the same *forked* repo, so refering to head
repo's "fork" field was not enough.

Fix #603
@haya14busa haya14busa mentioned this issue Jun 29, 2020
Merged
1 task
haya14busa added a commit that referenced this issue Jun 29, 2020
@haya14busa
Fix detection logic to determin Pull Requests from forked repo
be8cee2 
Head and base repos can be the same *forked* repo, so refering to head
repo's "fork" field was not enough.

Fix #603
@haya14busa haya14busa mentioned this issue Jun 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix detection logic to determin Pull Requests from forked repo reviewdog/reviewdog
1 participant
@haya14busa