New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check original line number and commit not to post same comments #87
Comments
I'm am, too, interested in this. Would you mind if I submit a pull request for this? |
Sure. Do you have some rough design or something? |
@haya14busa Did migrating to a checker fix this issue? |
yes. For check API, we don't need to care about this problem. reviewdog is still supporting reports through github review comments, so the problem isn't solved yet for -reporter=github-pr-review. but i'll close this issue for now because i don't have plan to work on this issue. maybe we can re-visit later. |
👍 Just curious, any particular reason to keep the old reviewer? Since the checks API seems better in every single way, maybe the old could be removed? |
New checks API is generally better, but the API is only available for GitHub apps. As for -reporter=github-pr-review feature, reviewdog CLI directly talks to GitHub with personal access token. For private repo users who don't want to, or it's difficult to trust my reviewdog server, it's better to use github-pr-review feature because it works standalone. As for OSS repository, I think users should choose github-pr-check reporter by default unless the reviewdog server is broken ;) |
@haya14busa Ok. In that case, this issue is still standing for private repos. Would you mind reopening it (and maybe modify description that it's only relevant for private repos)? Or would you like me to create a new issue?
Idea: 1) find the first comment by its own user and 2a) if found, modify the comment; otherwise 2b) post a new comment. This is what CodeCov does. See here for an example (click "Edited" in the comment header). What do you think of this approach? |
@haya14busa Ping. |
This may fixed one reviedog supports GitHub actions |
The latest reviewdog supports GitHub Action and can use github-pr-check reporter. |
No description provided.
The text was updated successfully, but these errors were encountered: