Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Pull Request Reviews for GitHub Enterprise #96

Closed
jcbwlkr opened this issue Jun 14, 2017 · 2 comments
Closed

Support Pull Request Reviews for GitHub Enterprise #96

jcbwlkr opened this issue Jun 14, 2017 · 2 comments

Comments

@jcbwlkr
Copy link

jcbwlkr commented Jun 14, 2017

Hello, haya14busa! Thanks for this great tool!

I can see in the code that reviewdog knows how to post comments in one big review but the behavior is disabled for Enterprise users. From what I can tell the Enterprise API now supports reviews. Can we get that feature enabled?
@haya14busa
Copy link
Member

Do you know how to check the review API is available or version of GHE?

Or, maybe we can totally disable old way to post comments?
Do you know when did the review API become available and GHE policy or something about updating version?

@jcbwlkr
Copy link
Author

jcbwlkr commented Jun 20, 2017

It looks to me that the review api became available in GHE v2.9. I can't tell if there is a way in the API to check your version. One option might be to do a GET against the reviews endpoint for a known PR and see if it 404s.

haya14busa added a commit that referenced this issue Aug 9, 2017
@haya14busa
Enable Pull Request Review API for GitHub Enterprise
0c132b3 
Now that Pull Request Review API became official[1], it's time to
use in GitHub Enterprise too.

If GitHub Enterprise version is too low to use new API, you should use
old review dog version. (<0.9.7)

[1]: https://developer.github.com/changes/2017-05-09-end-black-cat-preview/

Fixes #96
@haya14busa haya14busa mentioned this issue Aug 9, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jcbwlkr @haya14busa