Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove BlobHRef from struct of github.CheckRunAnnotation #309

Merged
merged 1 commit into from Sep 21, 2019
Merged

Remove BlobHRef from struct of github.CheckRunAnnotation #309

merged 1 commit into from Sep 21, 2019
+0 −2

Conversation

shopetan
Copy link
Contributor

@shopetan shopetan commented Sep 20, 2019 •
edited

What

I remove BlobHRef from struct of github.CheckRunAnnotation.

Why

Because removed variable in go-github repo. So I think It would be better to remove in this repo too.
FYI : google/go-github#1242

haya14busa
haya14busa approved these changes Sep 21, 2019
View reviewed changes
Copy link
Member

@haya14busa haya14busa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@haya14busa haya14busa merged commit b61b258 into reviewdog:master Sep 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haya14busa haya14busa haya14busa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shopetan @haya14busa