Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github-pr-review: use review summary comments for too many annotations #330

Merged
merged 6 commits into from Sep 29, 2019
Merged

github-pr-review: use review summary comments for too many annotations #330

merged 6 commits into from Sep 29, 2019

Commits on Sep 29, 2019

  1. github-pr-review: use review summary comments for too many annotations

    @haya14busa
    haya14busa committed Sep 29, 2019
    Copy the full SHA
    557b9c4 View commit details
    Browse the repository at this point in the history

  2. Use %f|%l col %c| as basic format to avoid emoji rendering 

    e.g. to avoid render `:100:`.

https://user-images.githubusercontent.com/3797062/65830668-7c796300-e2ec-11e9-9832-5e2212ab0284.png
    @haya14busa
    haya14busa committed Sep 29, 2019
    Copy the full SHA
    e84c9f7 View commit details
    Browse the repository at this point in the history

  3. github-pr-review: use <details> tag for summary

    @haya14busa
    haya14busa committed Sep 29, 2019
    Copy the full SHA
    3fd1a39 View commit details
    Browse the repository at this point in the history

  4. github-pr-review: remove abuse from a summary comment 

    `abuse` seems strong words and reviewdog users have no need to take care
about it.
    @haya14busa
    haya14busa committed Sep 29, 2019
    Copy the full SHA
    6bce37f View commit details
    Browse the repository at this point in the history

  5. githubutils: add tests

    @haya14busa
    haya14busa committed Sep 29, 2019
    Copy the full SHA
    ebce3fb View commit details
    Browse the repository at this point in the history

  6. github-pr-review: add simple test for summary text

    @haya14busa
    haya14busa committed Sep 29, 2019
    Copy the full SHA
    eba86ca View commit details
    Browse the repository at this point in the history