cmd: use CI_API_V4_URL env as gitlab API URL #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haya14busa
requested changes
May 7, 2020
cmd/reviewdog/main.go
Outdated
| baseURL := os.Getenv("GITLAB_API") | ||
| if baseURL == "" { | ||
| gitlabApi := os.Getenv("GITLAB_API") | ||
| gitlabV4Url := os.Getenv("CI_API_V4_URL") |
There was a problem hiding this comment.
gitlabV4URL.
Also, please fix the above golint error as well.
var gitlabApi should be gitlabAPI
cmd/reviewdog/main.go
Outdated
| gitlabV4Url := os.Getenv("CI_API_V4_URL") | ||
|
|
||
| var baseURL string | ||
| switch true { |
There was a problem hiding this comment.
Can you use if-else clause? It's interesting, but simple if-else should be better.
Alternatively, you can create another function which returns URL string and use early return.
There was a problem hiding this comment.
I thought about the function first, but then it seemed weird to me to have the current gitlabBaseURL to just be a wrapper for url.Parse. I have switched to the if-else chain.
|
Also, can you update Unreleased section in the changelog as well? https://github.com/reviewdog/reviewdog/blob/master/CHANGELOG.md |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be a simple change, although it has not been extensively tested.
Closes #563.