Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github-pr-review: Support multiline comments #680

Merged
merged 9 commits into from
Jul 22, 2020
Merged

github-pr-review: Support multiline comments #680

merged 9 commits into from
Jul 22, 2020

Conversation

haya14busa
Copy link
Member

  • Updated Unreleased section in CHANGELOG or it's not notable changes.

_testdata/custom.go Outdated Show resolved Hide resolved
_testdata/custom.go Outdated Show resolved Hide resolved
_testdata/custom.go Outdated Show resolved Hide resolved
_testdata/custom.go Outdated Show resolved Hide resolved
_testdata/custom.go Outdated Show resolved Hide resolved
_testdata/custom.go Outdated Show resolved Hide resolved
_testdata/custom.go Outdated Show resolved Hide resolved
_testdata/custom.go Outdated Show resolved Hide resolved
Comment on lines +5 to +9
--- Range
a = 1
b = 2
c = 3
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[multiline-test] reported by reviewdog 🐶
multiline test 1


line 5

--- Range
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[multiline-test] reported by reviewdog 🐶
multiline test 2 (same line)

line 5

--- Range
a = 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[multiline-test] reported by reviewdog 🐶
multiline test 3 (with line-break)

Comment on lines +6 to +8
a = 1
b = 2
c = 3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[multiline-test] reported by reviewdog 🐶
multiline test 4 (with line-break)

Comment on lines +5 to +9
--- Range
a = 1
b = 2
c = 3
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[multiline-test] reported by reviewdog 🐶
multiline test 1

Comment on lines +6 to +8
a = 1
b = 2
c = 3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[multiline-test] reported by reviewdog 🐶
multiline test 4 (with line-break)

line 5

--- Range
a = 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[multiline-test] reported by reviewdog 🐶
multiline test 3 (with line-break)

Comment on lines +6 to +8
a = 1
b = 2
c = 3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[multiline-test] reported by reviewdog 🐶
multiline test 4 (with line-break)

line 5

--- Range
a = 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[multiline-test] reported by reviewdog 🐶
multiline test 3 (with line-break)

Comment on lines +6 to +8
a = 1
b = 2
c = 3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[multiline-test] reported by reviewdog 🐶
multiline test 4 (with line-break)

# ------------------------ >8 ------------------------
# reviewdog results
# ------------------------ >8 ------------------------
# reviewdog results
# ------------------------ >8 ------------------------
# reviewdog results
# ------------------------ >8 ------------------------
# reviewdog results
# ------------------------ >8 ------------------------
# reviewdog results
To avoid other linters comments such as golint.
# ------------------------ >8 ------------------------
# reviewdog results
GitHub API returns position/line as end line for multiline comments.
# ------------------------ >8 ------------------------
# reviewdog results
# ------------------------ >8 ------------------------
# reviewdog results
…iff context.

Removed LnumDiff usage as well.

GitHub API error:
Line must be part of the diff and Start line must be part of the same
hunk as the line.
# ------------------------ >8 ------------------------
# reviewdog results
@haya14busa haya14busa merged commit ff11c86 into master Jul 22, 2020
@haya14busa haya14busa deleted the multilines branch July 22, 2020 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant