New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doghouse: Use shared http.RoundTripper #682

Merged

haya14busa merged 1 commit into master from share-round-trip

Jul 22, 2020

Member

haya14busa commented Jul 22, 2020

Updated Unreleased section in CHANGELOG or it's not notable changes.

// The provided tr http.RoundTripper should be shared between multiple
// installations to ensure reuse of underlying TCP connections.

https://github.com/bradleyfalzon/ghinstallation/blob/81f7095e75089d688962bb75ba9814748d90f004/transport.go#L72-L73


          doghouse: Use shared http.RoundTripper

377780b

// The provided tr http.RoundTripper should be shared between multiple
// installations to ensure reuse of underlying TCP connections.

https://github.com/bradleyfalzon/ghinstallation/blob/81f7095e75089d688962bb75ba9814748d90f004/transport.go#L72-L73
# ------------------------ >8 ------------------------
# reviewdog results

Member Author

haya14busa commented Jul 22, 2020

Potentially related with #681, but probably not.

haya14busa merged commit f20446e into master

haya14busa deleted the share-round-trip branch

July 22, 2020 14:32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment