Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support variables in optional parameter transformers #940

Closed
zolamk opened this issue Jun 2, 2023 · 1 comment
Closed

support variables in optional parameter transformers #940

zolamk opened this issue Jun 2, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@zolamk
Copy link
Contributor

zolamk commented Jun 2, 2023

Describe the bug

We currently have a set of transformer functions that provide default values to built-ins which have optional arguments the problem is with the introduction of variables in the reviewpad/backlog#158 it is not possible to pass variables to built-ins I suspect the transformer functions will start to fail when a variable is used, we need to investigate and fix the transformer functions to support variables

How to reproduce

for example doing $assignReviewer($teamMembers, 1)

Expected behavior

Transformer functions should work with variables

@zolamk zolamk added the bug Something isn't working label Jun 2, 2023
@zolamk zolamk changed the title support variables in optional variables transformers support variables in optional parameter transformers Jun 2, 2023
@zolamk
Copy link
Contributor Author

zolamk commented Jun 8, 2023

Closed by #944

@zolamk zolamk closed this as completed Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant