fix: consider variables in transformer functions #944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reviewpad
bot
added
ship
![reviewpad[bot]](https://avatars.githubusercontent.com/in/196990?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Considers variables when providing defaults to built-ins with regular expressions.
Summary generated by Reviewpad on 06 Jun 23 12:48 UTC
This pull request updates the addDefaultsToRequestedReviewers() function in the engine/transform.go file to allow for optional arguments for total required reviewers and policy. Additionally, a regular expression used to match the input has been updated, and several other functions have been updated to handle optional arguments.
copilot:summary
Code review and merge strategy
Ship: this pull request can be automatically merged and does not require code review
How
copilot:walkthrough