feat: remove mocks files from code coverage #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reviewpad-bot
added
small
marcelosousa
reviewed
Aug 1, 2022
marcelosousa
approved these changes
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces the removal of mock files in the code coverage by adding the file path pattern that matches
/mocks.gotoexclude-from-code-coverage.txtwhich is a file containing the file patterns regex which will be consumed by theexclude-from-code-coverage.shscript that removes from the code coverage the files that match the file patterns mentioned before.Related issue
Closes #191
Type of change
Improvements (non-breaking change without functionality)
How was this tested?
Ran the
go tool cover -func coverage.outthat lists the files part of the code coverage with the covered percentage and it also presents at the end the total coverage percentage - with this it was verified that the parser and mock files didn't belong to this listing and the total coverage increased.Checklist
task check -fand have no issues