Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: recipes #478

Merged
merged 17 commits into from
Jan 15, 2023
Merged

feat: recipes #478

merged 17 commits into from
Jan 15, 2023

Conversation

zolamk
Copy link
Contributor

@zolamk zolamk commented Nov 28, 2022 •
edited by ferreiratiago
Loading

Description

This PR integrates recipes from the cookbook

Related issue

Type of change

New feature (non-breaking change which adds functionality)

How was this tested?

Unit & Manual Tests

Checklist

  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works
  • I have ran task check -f and have no issues

Code review and merge strategy (ship/show/ask)

  • Ask: this pull request requires a code review before merge

@reviewpad reviewpad bot added ask Pull request requires a code review before merge run-build Label that controls when build should be executed external-contribution External contribution labels Nov 28, 2022
@reviewpad reviewpad bot added the large large pull request label Nov 28, 2022
@reviewpad reviewpad deleted a comment from reviewpad bot Nov 29, 2022
@reviewpad reviewpad bot added the waiting-review PR waiting for review label Nov 29, 2022
@reviewpad reviewpad deleted a comment from reviewpad bot Nov 30, 2022
@reviewpad reviewpad deleted a comment from reviewpad bot Dec 1, 2022
@reviewpad reviewpad deleted a comment from reviewpad bot Dec 2, 2022
@reviewpad reviewpad deleted a comment from reviewpad bot Dec 3, 2022
@ferreiratiago ferreiratiago requested review from ferreiratiago and removed request for marcelosousa December 3, 2022 11:24
@reviewpad reviewpad deleted a comment from reviewpad bot Dec 4, 2022
@ferreiratiago ferreiratiago added this to the Release v3.17.0 milestone Dec 5, 2022
@ferreiratiago
Copy link
Member

This pull request is on hold due to low priority.

@reviewpad
Copy link

reviewpad bot commented Dec 20, 2022 •
edited
Loading

Reviewpad Report

⚠️ Warnings

  • The pull request does not have a linear history

‼️ Errors

  • Unconventional commit detected: 'merge "origin/feat/recipes" into feat/recipes' (c97199e)

ℹ️ Messages

  • This pull request does not have a linked issue
  • @marcelosousa: you are being notified because critical code was modified

@ferreiratiago ferreiratiago modified the milestones: v3.20.0, v3.21.0 Dec 29, 2022
@ferreiratiago ferreiratiago modified the milestones: v3.21.0, v3.22.0 Jan 9, 2023
@reviewpad reviewpad bot added the medium medium pull request label Jan 14, 2023
@reviewpad reviewpad bot added the critical Modifications to critical changes label Jan 15, 2023
@ferreiratiago ferreiratiago marked this pull request as ready for review January 15, 2023 15:26
@reviewpad reviewpad bot removed the waiting-review PR waiting for review label Jan 15, 2023
@ferreiratiago ferreiratiago merged commit 9802361 into main Jan 15, 2023
@ferreiratiago ferreiratiago deleted the feat/recipes branch January 15, 2023 15:31
@reviewpad
Copy link

reviewpad bot commented Jan 15, 2023

📈 Pull Request Metrics

💻 Coding Time: 5 days
🛻 Pickup Time: 1 month
👀 Review Time: 1 minute

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferreiratiago ferreiratiago ferreiratiago approved these changes

Assignees

@marcelosousa marcelosousa

@ferreiratiago ferreiratiago

@zolamk zolamk

Labels
ask Pull request requires a code review before merge critical Modifications to critical changes external-contribution External contribution large large pull request low priority medium medium pull request run-build Label that controls when build should be executed
Projects
None yet
Milestone
v3.22.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zolamk @ferreiratiago @marcelosousa