feat: command error as comment #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… generated by a command
reviewpad
bot
added
ask
|
This pull request is on hold due to low priority. |
|
Reviewpad Report
ℹ️ Messages
|
ferreiratiago
requested changes
Jan 2, 2023
lang/aladino/env.go
Outdated
| @@ -51,6 +52,7 @@ type BaseEnv struct { | |||
| RegisterMap RegisterMap | |||
| Report *Report | |||
| Target codehost.Target | |||
| EventData *handler.EventData | |||
There was a problem hiding this comment.
Why do we need EventData? EventPayload should be enough for what we need here. WDYT?
There was a problem hiding this comment.
Yeah, makes perfect sense, thank you
| @@ -9,7 +9,8 @@ type Statement struct { | |||
| } | |||
|
|
|||
| type Program struct { | |||
| statements []*Statement | |||
| IsFromCommand bool | |||
There was a problem hiding this comment.
IsFromCommand should be another property of the env in which the program is running. I would suggest moving this into the BaseEnv. WDYT?
There was a problem hiding this comment.
This one I think better to keep it in the program since we are checking if it's a command after the BaseEnv is built I think, what do you think @ferreiratiago
reviewpad
bot
added
the
requires-author-attention
ferreiratiago
approved these changes
Jan 13, 2023
📈 Pull Request Metrics💻 Coding Time: 1 day |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, a command might be syntactically correct but during execution of the generated program for a command an error might happen which makes it seem like it's a reviewpad error when in a reality it was the command that failed because of wrong input so this PR provides feedback to the user in the form of a GitHub comment.
Related issue
Closes #471
Type of change
Improvements (non-breaking change without functionality)
How was this tested?
Unit tests and Manual tests
Checklist
task check -fand have no issuesCode review and merge strategy (ship/show/ask)