Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce robin client #771

Merged
merged 2 commits into from
Mar 13, 2023
Merged

feat: introduce robin client #771

merged 2 commits into from
Mar 13, 2023

Conversation

marcelosousa
Copy link
Member

Description

This pull request replaces the interface to interact with Robin from a Golang library to a gRPC client.

Related issue

Closes #770.

Type of change

New feature (non-breaking change which adds functionality)

Checklist

  • I have performed a self-review of my code
  • I have ran task check -f and have no issues

Code review and merge strategy (ship/show/ask)

Show: this pull request can be auto-merged and a code review should be done post-merge

@reviewpad-stage reviewpad-stage bot added new-feature Non-breaking change which adds functionality show Pull request can be auto-merged and a code review should be done post-merge medium medium pull request waiting-review PR waiting for review plugins Modifications to the plugins directory labels Mar 10, 2023
@reviewpad-stage
Copy link

reviewpad-stage bot commented Mar 10, 2023

Reviewpad Report

ℹ️ Messages

  • If you are adding or updating a built-in, please do not forget to update the docs

@reviewpad-stage
Copy link

The changes include adding a new service called "robin" in the Aladino plugin, and a corresponding client to interact with it. The first patch adds new code to support this service, while the second patch removes some lines that were previously used to post comments of the reply of the prompt.

It's hard to say whether these changes are critical without additional context on the functionality and importance of the "robin" service. However, based on the commit messages, these changes seem like additions and updates rather than critical fixes.

@marcelosousa marcelosousa merged commit f5c1a2d into main Mar 13, 2023
@marcelosousa marcelosousa deleted the feat/robin-client branch March 13, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium medium pull request new-feature Non-breaking change which adds functionality plugins Modifications to the plugins directory show Pull request can be auto-merged and a code review should be done post-merge waiting-review PR waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate Robin Client
1 participant