Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for $commits function builtin #79

Merged
merged 4 commits into from
Jul 11, 2022
Merged

Add unit tests for $commits function builtin #79

merged 4 commits into from
Jul 11, 2022

Conversation

shay2025
Copy link
Contributor

@shay2025 shay2025 commented Jul 7, 2022 •
edited
Loading

Description

This pull request adds unit tests for the $commits function builtin and it paginates the ListCommits github request.

Related issue

Closes #46

Type of change

Improvements (non-breaking change without functionality)

How was this tested?

Ran the command task test.

Checklist

  • I have performed a self-review of my code
  • I have ran task check -f and have no issues

@github-actions github-actions bot added the large large pull request label Jul 7, 2022
@shay2025 shay2025 force-pushed the test/commits-function branch 2 times, most recently from 3187917 to be9aae9 Compare July 7, 2022 16:21
@reviewpad-bot reviewpad-bot added the run-build Label that controls when build should be executed label Jul 7, 2022
@shay2025 shay2025 marked this pull request as draft July 11, 2022 08:56
@reviewpad-bot reviewpad-bot added the plugins Modifications to the plugins directory label Jul 11, 2022
@reviewpad-bot
Copy link

Reviewpad Report

ℹ️ Messages

  • If you are adding or updating a built-in, please do not forget to update the docs
  • If you have added a new function or action do not forget to include it in the built-in list!

@shay2025 shay2025 marked this pull request as ready for review July 11, 2022 10:20
ferreiratiago
ferreiratiago approved these changes Jul 11, 2022
View reviewed changes
Copy link
Member

@ferreiratiago ferreiratiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shay2025 shay2025 merged commit 52bb781 into main Jul 11, 2022
@shay2025 shay2025 deleted the test/commits-function branch July 11, 2022 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelosousa marcelosousa Awaiting requested review from marcelosousa

@ferreiratiago ferreiratiago Awaiting requested review from ferreiratiago

Assignees
No one assigned
Labels
large large pull request plugins Modifications to the plugins directory run-build Label that controls when build should be executed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Paginate list commits request in aladino commits
3 participants
@shay2025 @reviewpad-bot @ferreiratiago