feat: compact format for if, then and actions

[zolamk]

Description

Introduces a compact form for if, then and actions fields in reviewpad file.

workflows:
  - name: add-label
    if: '$size() <= 30'
    then: '$addLabel("small")'

pipelines:
  - name: renovate-bot
    trigger: $author() == "renovate[bot]"
    stages:
      - actions: $assignAssignees($group("owners"), 1)
        until: $assignees() != []

Related issue

Closes reviewpad/raas-common#103

Type of change

New feature (non-breaking change which adds functionality)

How was this tested?

Manual and Unit tests.

Checklist

• I have performed a self-review of my code
• I have added tests that prove my fix/feature works (if applicable) and have tested properly
• I have ran task check -f and have no issues

Code review and merge strategy (ship/show/ask)

Ask: this pull request requires a code review before merge

[reviewpad]

AI-Generated Summary: This pull request contains two patches:

1. The first patch adds support for compact if-then actions in the engine, updating functions and modifying some structs to include the new functionality.
2. The second patch introduces test coverage that checks the correct handling of multiple compact inline actions and pipelines with compact actions. Several test files are added for input and expected processed output for these test cases.

[reviewpad]

Reviewpad Report

‼️ Errors

• The pull request does not have a linked issue. Please link one. Reviewpad will only assign a reviewer when the pull request is linked to an issue.

[adrianoapmartins]

/reviewpad summarize

[reviewpad]

AI-Generated Summary: This pull request contains two patches that introduce support for compact if-then actions and adds test coverage for them.

The first patch modifies the engine/inline_rules_normalizer.go, engine/lang.go, and engine/loader.go files to add support for compact if-then actions. It primarily involves refactoring some functions, adding helper functions for processing compact rules and actions, and updating the data structures to handle the new format.

The second patch adds new test cases to the engine/loader_test.go and includes the associated YAML files for testing. It tests the handling of files with multiple inline actions and multiple pipelines with compact actions.

[ferreiratiago]

Is this required? From my understanding, actions can either be a string or a list. In the last case, we can iterate and append. Does running processCompactActions is necessary?

[zolamk]

we are gonna have to check the list elements are a string right, instead of repeating that in the loop I figured we could reuse it

[ferreiratiago]

Why nil? What is the use case for nil? In this case shouldn't we return an empty list, i.e. actions?

[zolamk]

that's in case the workflow doesn't have any actions but only extra actions associated with the rules

[ferreiratiago]

Shouldn't this be []string?

[zolamk]

since it's an interface{} type we are processing the type will be []any instead of []string

[ferreiratiago]

If my understanding is correct being string can mean the name of a specified rule under rules, which means that this decode is not correct. It works because on line 136 we look for all rules and we will end up with the correct spec.

We don't need to correct this since it's working and we will be addressing this issue later.

Just wanted to create awareness.

[zolamk]

Yes, this is just creating a rule structure using the spec as a name and we verify it doesn't exist at a later stage, it was a way of avoiding having duplicate rules if the same spec is repated

[reviewpad]

AI-Generated Summary: This pull request includes 3 commits that add support for compact if-then actions, provide test coverage for those actions, and address reviews. The changes involve modifications to the engine/inline_rules_normalizer.go, engine/lang.go, engine/loader.go, and engine/loader_test.go files along with the addition of new test files.

1. In the first commit, engine/inline_rules_normalizer.go is updated to support compact if-then actions, with functions like processWorkflow, normalizeRules and normalizeActions added or updated.
2. The second commit adds test coverage for compact if-then actions. Six test files are added and updated in the engine package, and a test case for multiple inline actions is added in engine/loader_test.go.
3. The third commit includes a refactor to address reviews, with changes mainly in engine/inline_rules_normalizer.go.

[reviewpad]

📈 Pull Request Metrics

💻 Coding Time: 12 minutes
🛻 Pickup Time: 4 days
👀 Review Time: 19 hours