Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add dismissed review event to map of review state to event #826

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

zolamk
Copy link
Contributor

@zolamk zolamk commented Apr 8, 2023

Description

Fixes a bug on the $review built-in action where an error occurs if the previous review was dismissed by the user.

馃 Generated by Copilot at 0830bbf

Handle dismissed reviews in Reviewpad. Add a case for DISMISSED state in plugins/aladino/actions/review.go.

Related issue

Closes #788

Type of change

Bug fix (non-breaking change which fixes an issue)

How was this tested?

Manual tests

Checklist

  • I have performed a self-review of my code
  • I have added tests that prove my fix/feature works (if applicable) and have tested properly
  • I have ran task check -f and have no issues

Code review and merge strategy (ship/show/ask)

Ask: this pull request requires a code review before merge

HOW

馃 Generated by Copilot at 0830bbf

  • Add a new case for the "DISMISSED" review state in the switch statement that maps a state to an event (link)

@reviewpad reviewpad bot added bug-fix Non-breaking change which fixes an issue ask Pull request requires a code review before merge small small pull request labels Apr 8, 2023
@reviewpad
Copy link

reviewpad bot commented Apr 8, 2023

AI-Generated Summary: This pull request adds the missing "DISMISSED" review event to the function mapReviewStateToEvent in the plugins/aladino/actions/review.go file. The update ensures that the dismissed review state is properly handled and mapped to its corresponding event.

@reviewpad reviewpad bot added the plugins Modifications to the plugins directory label Apr 8, 2023
@reviewpad
Copy link

reviewpad bot commented Apr 8, 2023

Reviewpad Report

鈩癸笍 Messages

  • If you are adding or updating a built-in, please do not forget to update the docs
  • If you have added a new function or action do not forget to include it in the built-in list!

鈥硷笍 Errors

  • You have too many open pull requests. Please close some of them before opening a new one. Reviewpad will only assign a reviewer when you have less than 3 open pull requests.

@zolamk zolamk marked this pull request as ready for review April 8, 2023 15:00
@ferreiratiago ferreiratiago merged commit a696f20 into main Apr 12, 2023
@ferreiratiago ferreiratiago deleted the fix/dismissed-review-event branch April 12, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ask Pull request requires a code review before merge bug-fix Non-breaking change which fixes an issue plugins Modifications to the plugins directory small small pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate review state DISMISSED
2 participants