Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: merge and fail check run messages #899

Merged
merged 2 commits into from
May 22, 2023

Conversation

zolamk
Copy link
Contributor

@zolamk zolamk commented May 22, 2023

Description

Adjusts the $merge and $failCheckStatus built-in check run messages to make it a bit more clear to the user.

Summary generated by Reviewpad on 22 May 23 07:24 UTC

This pull request contains two refactor patches. The first patch removes the policy from the check run title, while the second patch changes the check run summary if Reviewpad fails to merge.

馃 Generated by Copilot at 0c8d532

Refactor and simplify aladino plugin actions. Extract common code for check run updates to a helper function. Improve error handling and output titles.

Code review and merge strategy

Ship: this pull request can be automatically merged and does not require code review

How

馃 Generated by Copilot at 0c8d532

  • Simplify check run output title for reviewpad plugin (link)
  • Refactor code to update check run status and output before merging pull request using a helper function updateCheckRunWithSummary (link, link)
  • Handle merge failure due to branch protection rules and update check run status and output accordingly (link)
  • Remove unused variable assignment in merge.go (link)

@reviewpad reviewpad bot added ship Pull request can be automatically merged and does not require code review medium medium pull request plugins Modifications to the plugins directory labels May 22, 2023
Copy link

@reviewpad reviewpad bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request is in ship mode. Reviewpad will merge it.

@reviewpad reviewpad bot merged commit 36dfadf into main May 22, 2023
5 checks passed
@reviewpad reviewpad bot deleted the refactor/merge-fail-messages branch May 22, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium medium pull request plugins Modifications to the plugins directory ship Pull request can be automatically merged and does not require code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant