Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add checks #987

Merged
merged 1 commit into from
Jul 17, 2023
Merged

feat: add checks #987

merged 1 commit into from
Jul 17, 2023

Conversation

ferreiratiago
Copy link
Member

@ferreiratiago ferreiratiago commented Jul 15, 2023

Description

Summary generated by Reviewpad on 17 Jul 23 16:45 UTC

This pull request adds checks to the Reviewpad file. It also includes some code refactoring and test improvements. Overall, it adds 61 insertions and modifies 5 deletions across 4 files.

馃 Generated by Copilot at 82bdf31

This pull request adds support for checks in reviewpad files, which are custom rules or validations for the code under review. It defines the PadCheck struct and its methods, and modifies the ReviewpadFile struct and its methods to handle checks. It also updates the loader, the inline rules normalizer, and the loader test to work with checks.

Code review and merge strategy

Show: this pull request can be auto-merged and a code review should be done post-merge

How

馃 Generated by Copilot at 82bdf31

  • Add the Checks field to the inlineModificator struct to allow custom checks for rules or pipelines (link)
  • Remove unused edition constants from the engine package (link)
  • Add the Checks field to the ReviewpadFile struct and the PadCheck struct to represent checks in the reviewpad file (link, link)
  • Modify the equals and extend methods of the ReviewpadFile struct to compare and merge checks (link, link)
  • Add the Checks field to the ReviewpadFileAST struct and copy it in the transform function (link, link)
  • Add the appendChecks method to the ReviewpadFile struct and call it in the processImports function to handle imported checks (link, link)
  • Update the TestLoadWithAST function to initialize the Checks field in the expected reviewpad file (link)

@reviewpad reviewpad bot added the show Pull request can be auto-merged and a code review should be done post-merge label Jul 15, 2023
@ferreiratiago ferreiratiago marked this pull request as ready for review July 17, 2023 16:45
@reviewpad reviewpad bot added the medium medium pull request label Jul 17, 2023
Copy link

@reviewpad reviewpad bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request is in show mode. Reviewpad will merge it. @ferreiratiago kindly reminder to add this pull request to the meeting agenda where pull requests with the show strategy are reviewed.

@reviewpad reviewpad bot added this pull request to the merge queue Jul 17, 2023
Merged via the queue into main with commit 587d3a5 Jul 17, 2023
3 checks passed
@ferreiratiago ferreiratiago deleted the feat/padcheck branch August 18, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium medium pull request show Pull request can be auto-merged and a code review should be done post-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant