Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add built-in dictionaryValueFromKey #999

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

ferreiratiago
Copy link
Member

@ferreiratiago ferreiratiago commented Jul 26, 2023

Description

Summary generated by Reviewpad on 26 Jul 23 10:38 UTC

This pull request adds a new built-in function called "dictionaryValueFromKey" to the "aladino" plugin. This function allows retrieving the value of a specific key from a dictionary. The function takes two arguments: the name of the dictionary and the key to retrieve. If the dictionary and key exist, the function returns the corresponding value. Otherwise, it returns an error message. This patch also includes the necessary changes to the go.mod and go.sum files.

🤖 Generated by Copilot at ba8d429

Updated the reviewpad/api/go module and added a new aladino built-in function dictionaryValueFromKey that allows accessing values from predefined dictionaries in the aladino environment. This function can be used for both pull requests and issues.

Related to

Closes #998

Code review and merge strategy

Show: this pull request can be auto-merged and a code review should be done post-merge

How

🤖 Generated by Copilot at ba8d429

  • Update go module dependency to use latest reviewpad/api/go version (link)
  • Add dictionaryValueFromKey built-in function to aladino plugin system (link, link)

@reviewpad reviewpad bot added show Pull request can be auto-merged and a code review should be done post-merge medium medium pull request plugins Modifications to the plugins directory labels Jul 26, 2023
Copy link

@reviewpad reviewpad bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request is in show mode. Reviewpad will merge it. @ferreiratiago kindly reminder to add this pull request to the meeting agenda where pull requests with the show strategy are reviewed.

@reviewpad reviewpad bot added this pull request to the merge queue Jul 26, 2023
Merged via the queue into main with commit deb894b Jul 26, 2023
4 checks passed
@ferreiratiago ferreiratiago deleted the feat/builtin-dictionaryValueFromKey branch August 18, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium medium pull request plugins Modifications to the plugins directory show Pull request can be auto-merged and a code review should be done post-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a $dictionaryValueFromKey(dictionary, key) built-in to get access to a dictionary value
1 participant