Fix a bug in Giveaways Extractor that happens when opening in a new tab

[at46]

It opens a new tab but keeps loading forever with 0 GA extracted. Error since 7.7.3 or 7.7.4. New option for extract from this point forward is disabled. Console shows "Promise rejection value is a non-unwrappable cross-compartment wrapper."

[rafaelgomesxyz]

What browser? And are you using the script or extension?

[at46]

Firefox 56 and script with greasemonky 3.17.

[rafaelgomesxyz]

Does it happen for every train? I'm not experiencing it.

[at46]

Every train and every post with GAs in it. But only in new tabs. If I disable open in new tab everything works.

[rafaelgomesxyz]

Ah, that definitely helps. Will fix in the next version.

[randomname42]

Posting this just in case it helps narrows down the problem.

I think I might be seeing the same thing, except it's only stuck at 0 extracted when opening a new tab from a forum post. Works fine if you open the first giveaway in a train and extract to a new tab from there.

[rafaelgomesxyz]

I already fixed it, as you can see in the commit above. I'll release the new version publicly on Saturday.

[randomname42]

I'm using 7.9.0 of the extension now and I'm still seeing 0 giveaways extracted when trying to extract to new tab from a discussion page. Works when extracting from the first giveaway page of a train, it's just extracting from a discussion page which doesn't work.

I'm on Firefox if that makes a difference.

[at46]

For me everything works fine since 7.8.0 (and also with 7.9.0). Which version of Firefox do you use? ESGST script or addon? Greasemonkey version? Does the bug only occur with the option to open in a new tab?

[randomname42]

Only fails on new tab. Addon version. Firefox 56.

I need far too many things that only legacy addons can do, so downgrading to Firefox 57 (for me it would be a massive downgrade due to lost functionality, not an upgrade) is not something I can do.

The reduced functionality of noscript, and the loss of session manager alone would be a dealbreaker. Besides that about 90% of the other addons I use never got changed over to the new system, and have no good equivalents.

I'm planning to switch to Waterfox once they get some profile issues fixed. So many people I know are switching over to that. Cutting out legacy addons when the new extension type still doesn't have many permissions granted which would be needed to allow many addons to be ported... it's boneheaded.

Sorry about the FF rant. I do have to ask this. Is there any chance Waterfox going to be supported going forward?

[rafaelgomesxyz]

@randomname42 Sorry, I forgot about this. Are you still having problems? I don't know if Waterfox is going to be supported, I've never heard of it, if it has the same API that Firefox has it should work fine.

[randomname42]

Yep, still happening. It looks like this when trying to extract a train from this discussion page, for example. That happens always when extracting from a discussion page.

Waterfox is basically Firefox but keeping legacy addons enabled (which is why many are going to it now that Firefox disabled them) and a few things removed (like telemetry for example). It should be the same as regular Firefox with the new addon type though. Waterfox just allows the old kind to still work as well.

I'm still on Firefox 56 btw, but I don't know any reason that should affect ESGST.