Merge pull request #1 from saber3005/duplicate-set-operations

Stop redundant `set`s
revinate · Mar 9, 2016 · e5b4e39 · e5b4e39
2 parents 66b894a + e577335
commit e5b4e39
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/setValueFunctions.php b/src/setValueFunctions.php
@@ -95,5 +95,8 @@ function setValueByArrayPath($doc, $fieldPath, $value) {
     $fieldName = array_shift($fieldPath);
     $subDoc = getValue($doc, $fieldName, array());
     $subDocUpdated = setValueByArrayPath($subDoc, $fieldPath, $value);
-    return setValue($doc, $fieldName, $subDocUpdated);
+    if ($subDocUpdated !== $subDoc) {
+        $doc = setValue($doc, $fieldName, $subDocUpdated);
+    }
+    return $doc;
 }