-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Region delivery limitations does not work as expected with "Is not any of" #459
Comments
Please consider posting your question on the community forums at http://forum.revive-adserver.com |
Can you please post the IP address that you say is from Israel? |
I've been able to replicate the issue. As it is now, it appears that the delivery limitation is applied as "country being US and state not any of [Florida]". As far as I know it has been interpreted like this since ages, and I would be reluctant to change it in a minor release, even if I think it is a bug. It could be something to consider for fixing in 3.2. As a workaround you could add one more condition, like "country NOT US", making sure the operand is "OR". |
This needs some new documentation to help make it easier to understand how things work currently - I have this on my list to do as part of preparations for the 4.0.2 release. |
Oh, rats. I forgot - I haven't done any geotargeting documentation at all yet. This makes it hard to add a note to talk about how this works! I have bumped this to the 4.1.0 release for now, but I will put geotargeting documentation higher on my list of things to do re: user documentation. Sorry for the delay. |
This shall be documented at some point at https://documentation.revive-adserver.com/display/DOCS/Geotargeting+Delivery+Rules |
Since this issue is not going to be extremely common, I think it's OK to close this here and refer to the documentation. I've added a link on that page referring back to this issue, so that readers looking for it can easily find it while looking for documentation on setting geotargeting rules. |
This is now documented. |
When limiting a banner with:
"Is not any of":
Country: United States
Region: Florida
What happens:
Connecting from New York: banner is delivered (expected to deliver)
Connecting from Florida: banner is not delivered (expected not to deliver)
Connecting from Israel: banner is not delivered (expected to deliver!)
Using the latest version of GeoIP database. Double-checked that the IPs I do checks from are detected correctly by Revive.
The text was updated successfully, but these errors were encountered: