Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Region delivery limitations does not work as expected with "Is not any of" #459

Closed
Zer0Divis0r opened this issue Jan 8, 2015 · 8 comments
Assignees
Milestone

Comments

@Zer0Divis0r
Copy link
Contributor

When limiting a banner with:
"Is not any of":
Country: United States
Region: Florida

What happens:
Connecting from New York: banner is delivered (expected to deliver)
Connecting from Florida: banner is not delivered (expected not to deliver)
Connecting from Israel: banner is not delivered (expected to deliver!)

Using the latest version of GeoIP database. Double-checked that the IPs I do checks from are detected correctly by Revive.

@erikgeurts
Copy link
Contributor

Please consider posting your question on the community forums at http://forum.revive-adserver.com

@erikgeurts
Copy link
Contributor

Can you please post the IP address that you say is from Israel?

@erikgeurts erikgeurts reopened this Jan 8, 2015
@mbeccati
Copy link
Contributor

mbeccati commented Jan 8, 2015

I've been able to replicate the issue. As it is now, it appears that the delivery limitation is applied as "country being US and state not any of [Florida]". As far as I know it has been interpreted like this since ages, and I would be reluctant to change it in a minor release, even if I think it is a bug.

It could be something to consider for fixing in 3.2.

As a workaround you could add one more condition, like "country NOT US", making sure the operand is "OR".

@mbeccati mbeccati added this to the Revive v4.0.0 milestone Jan 8, 2015
@mbeccati mbeccati added Bug and removed Question labels Jan 8, 2015
@andrewatfornax andrewatfornax self-assigned this Mar 10, 2015
@andrewatfornax andrewatfornax modified the milestones: v4.0.2, v5.0.0 Apr 4, 2017
@andrewatfornax
Copy link
Collaborator

This needs some new documentation to help make it easier to understand how things work currently - I have this on my list to do as part of preparations for the 4.0.2 release.

@andrewatfornax andrewatfornax removed the Bug label Apr 4, 2017
@andrewatfornax andrewatfornax modified the milestones: v4.1.0, v4.0.2 May 5, 2017
@andrewatfornax
Copy link
Collaborator

Oh, rats. I forgot - I haven't done any geotargeting documentation at all yet. This makes it hard to add a note to talk about how this works!

I have bumped this to the 4.1.0 release for now, but I will put geotargeting documentation higher on my list of things to do re: user documentation. Sorry for the delay.

@erikgeurts erikgeurts modified the milestones: v4.1.0, v4.1.1 Oct 20, 2017
@mbeccati mbeccati modified the milestones: v4.1.1, v4.1.2 Oct 24, 2017
@mbeccati mbeccati modified the milestones: v4.1.2, v4.1.4 Feb 8, 2018
@mbeccati mbeccati modified the milestones: v4.1.4, v4.2.0, v4.1.5 May 24, 2018
@erikgeurts erikgeurts modified the milestones: v4.1.5, v5.0.0 Aug 9, 2018
@andrewatfornax andrewatfornax modified the milestones: v5.1.0, v5.0.0 Aug 9, 2018
@erikgeurts
Copy link
Contributor

This shall be documented at some point at https://documentation.revive-adserver.com/display/DOCS/Geotargeting+Delivery+Rules

@erikgeurts
Copy link
Contributor

Since this issue is not going to be extremely common, I think it's OK to close this here and refer to the documentation.

I've added a link on that page referring back to this issue, so that readers looking for it can easily find it while looking for documentation on setting geotargeting rules.

@andrewatfornax
Copy link
Collaborator

This is now documented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants