Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Unknown operator" error in the banner Delivery Options #549

Closed
martinkrcho opened this issue May 12, 2015 · 3 comments
Closed

"Unknown operator" error in the banner Delivery Options #549

martinkrcho opened this issue May 12, 2015 · 3 comments
Labels
Milestone

Comments

@martinkrcho
Copy link

I have upgraded my instance of Revive from 3.0.5 to 3.2.0 yesterday. I am seeing an error message "Unknown operator" when trying to add date restrictions ("Time - Date") to a banner under the "Delivery Options" tab. The dropdown with the operator options only shows first two options the others are blank. This is the HTML code:

<select name="acl[0][comparison]" tabindex="2">
  <option value="==">is equal to</option>
  <option value="!=">is different from</option>
  <option value=">"></option><option value=">=">
  </option><option value="<" selected="">
  </option><option value="<="></option>
</select>

Is the same happening to somebody else? I tried switching the language to English thinking it's a translations issue, but it's not. Thanks.

@erikgeurts erikgeurts added the Bug label May 12, 2015
@erikgeurts erikgeurts added this to the Revive v3.2.1 milestone May 12, 2015
@erikgeurts
Copy link
Contributor

Thanks for your detailed report.

I can confirm that I'm seeing this too in a recently upgraded v3.2.0 installation:
image

This is most likely caused by the language file cleanup that was performed recently, it appears that some of the original English texts have been removed inadvertently.

@roybaum
Copy link

roybaum commented May 16, 2015

I, too, have seen this exact same error. I've tried installing 3.2.0 three times to two different hosts with the same result.

@steveganz
Copy link
Contributor

Here are the missing strings from /lib/max/language/en/default.lang.php:

    $GLOBALS['strLaterThan']                  = "is later than";
    $GLOBALS['strLaterThanOrEqual']           = "is later than or equal to";
    $GLOBALS['strEarlierThan']                = "is earlier than";
    $GLOBALS['strEarlierThanOrEqual']         = "is earlier than or equal to";
    $GLOBALS['strNotContains']                = "doesn't contain";

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants