Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sandboxing of iframe tags and asynchronous tags #806

Open
Zer0Divis0r opened this issue Jan 29, 2017 · 3 comments
Open

Sandboxing of iframe tags and asynchronous tags #806

Zer0Divis0r opened this issue Jan 29, 2017 · 3 comments
Labels

Comments

@Zer0Divis0r
Copy link
Contributor

Zer0Divis0r commented Jan 29, 2017

The problem of malvertising is becoming bigger issue all the time. I'd suggest adding an option to sandbox iframe tags, so that the stuff that runs in iframe would not be able to:

  • perform top-window redirects
  • run javascript (serve static HTML only)
  • open any new windows (not clickable banner, branded advertising, for example)
  • prevent content from using plugins (eg. if you want to block video when you sell placement for HTML ads only)
  • access publishers cookies

This is just the list of most basic limitations. Obviously, sandboxing should be very well documented to avoid confusion about things that would certainly not work. For example, video autoplay, access to window.top.location.href (and advise to use window.location.ancestorOrigins), etc.

I am sure that there is a wide range of measures that can be taken to secure asynchronous tags as well, since they also utilize iframes.

Also, installing Revive Adserver in a completely different TLD and using iframes can be a good security advise, since cross-origin iframes natively have good security limitations (CORS).

@Zer0Divis0r Zer0Divis0r changed the title Feature request: sandboxing of iframe tags Feature request: sandboxing of iframe tags and asynchronous tags Jan 29, 2017
@erikgeurts erikgeurts changed the title Feature request: sandboxing of iframe tags and asynchronous tags Sandboxing of iframe tags and asynchronous tags Jan 30, 2017
@jonas-eberle
Copy link

Has anyone tested the use of the HTML5 sandbox attribute? Sounds suitable for this:
https://www.w3schools.com/tags/att_iframe_sandbox.asp

@Zer0Divis0r
Copy link
Contributor Author

Yes. The list of sandboxing options I have suggested reflects available values of the sandbox HTML5 attribute.

@Zer0Divis0r
Copy link
Contributor Author

From my very recent experience, the sandboxing should be expanded far beyond just "sandbox" iframe attribute. An iab-compliant sandbox should be implemented in Revive, otherwise it leaves websites vulnerable to, for example. malicious redirects that can arrive from third-party ad tags.
This would also require from administrator to provide a separate domain that would serve the sandbox HTML code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants