Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apply orientation metadata to image uploads #21

Merged
merged 1 commit into from
May 9, 2022
Merged

fix: apply orientation metadata to image uploads #21

merged 1 commit into from
May 9, 2022

Conversation

sussycatgirl
Copy link
Member

Please make sure to check the following tasks before opening and submitting a PR

  • I understand and have followed the contribution guide
  • I have tested my changes locally and they are working as intended
  • These changes do not have any notable side effects on other Revolt projects

Fixes #20.

This PR adds kamadak-exif as a dependency to read EXIF metadata from uploaded image files.

For testing, here are 8 variants of the same image file created by an iPhone, with manipulated orientation metadata: exif_test.zip.

@insertish insertish merged commit 4a31ba8 into revoltchat:master May 9, 2022
@sussycatgirl sussycatgirl deleted the fix/image-rotation branch May 10, 2022 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: don't strip orientation EXIF data
2 participants