Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notify admin on 500 #90

Closed
jheld opened this issue Jan 27, 2017 · 4 comments
Closed

notify admin on 500 #90

jheld opened this issue Jan 27, 2017 · 4 comments
Assignees

Comments

@jheld
Copy link

jheld commented Jan 27, 2017

Would you accept a PR for implementing a custom setting (via a settings.py that reads from the project) to notify admins of 500s?
If True, and maybe some other fine-tuned details, the admin/people/endpoint will get notified of an error, and by default/False, they won't.

I realize monitoring and bot services can do this for us, but in the case of not using those services, it may be nice to have the option for a built-in version.

@codingjoe
Copy link
Collaborator

Sure we would! Make sure it's opt-in tho. Cool, I'm looking forward!

@codingjoe codingjoe self-assigned this Jan 27, 2017
@aleksihakli
Copy link
Contributor

Email based logging error reporting such as that Django has would be a great way to implement this.

If this could be integrated into the logging framework it could also notify other backends and console using the Django default logging API, producing more verbose and traceable messages.

@jheld
Copy link
Author

jheld commented Jan 28, 2017

It looks like the add_error method on BaseHealthCheckBackend already handles logging (by the health-check logger name). So, yeah, there may not even be a need to adjust the project at all. I think the onus would just be on the consumer project to ensure the health-check logger is defined.

Feel free to verify on your end.

@codingjoe
Copy link
Collaborator

Sure, a consumer would solve this issue. Further more, I think it is best to have an external service inform you about outage. What if you email server is the service that is down. You would never be notified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants