Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚜 Initial GitHub Actions integration #167

Merged
merged 28 commits into from May 20, 2021
Merged

🚜 Initial GitHub Actions integration #167

merged 28 commits into from May 20, 2021

Conversation

jefftriplett
Copy link
Member

@jefftriplett jefftriplett commented May 20, 2021

Fixes #162

This pull request:

  • Adds GHA support (via Matrix)
  • Adds 3.10 support
  • Drops Travis
  • Drops 3.5 in testing since it's well past EOL
  • Drops tox
  • Updates setup.cfg to make optional requirements installable

Could do:

  • Delete tox.ini, but I left it in case it's useful locally.

Follow up:

@jefftriplett jefftriplett changed the title WIP: 🚜 Initial GHA 🚜 Initial GitHub Actions integration May 20, 2021
@fcurella
Copy link
Collaborator

Why wouldn't we test against DRF in all jobs? I would just add djangorestframework to the test_requires

@jefftriplett
Copy link
Member Author

Why wouldn't we test against DRF in all jobs? I would just add djangorestframework to the test_requires

I noticed the old tests tested without it (see tox too for example) so I assumed we needed it. If it's not a big deal, then that checks a big ✅

@jefftriplett
Copy link
Member Author

@fcurella @frankwiles do either of you see an issue dropping Python 3.5? It's been EOL since December and pip + pytest no longer support it (not that I can't use older versions).

@fcurella
Copy link
Collaborator

Totally fine with dropping Py 3.5

@frankwiles
Copy link
Member

Yeah I'm fine with dropping 3.5, hell I'm ok with no longer even testing against 3.6 or at least not letting 3.6 compatibility cause us any work.

@jefftriplett
Copy link
Member Author

I'm going to leave 3.6 in since it's supported through 2021. Support doesn't seem to be an issue.

@jefftriplett jefftriplett merged commit 0360bf3 into master May 20, 2021
@jefftriplett jefftriplett deleted the github-actions branch May 20, 2021 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚜 Migrate CI to GitHub Actions
3 participants