-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚜 Initial GitHub Actions integration #167
Conversation
Why wouldn't we test against DRF in all jobs? I would just add |
I noticed the old tests tested without it (see tox too for example) so I assumed we needed it. If it's not a big deal, then that checks a big ✅ |
@fcurella @frankwiles do either of you see an issue dropping Python 3.5? It's been EOL since December and pip + pytest no longer support it (not that I can't use older versions). |
Totally fine with dropping Py 3.5 |
Yeah I'm fine with dropping 3.5, hell I'm ok with no longer even testing against 3.6 or at least not letting 3.6 compatibility cause us any work. |
I will do a follow up PR to restore this
I'm going to leave 3.6 in since it's supported through 2021. Support doesn't seem to be an issue. |
Fixes #162
This pull request:
Could do:
Follow up: