fix: Fix issues in asset centering, auto-cropping and processing #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes issue where cover image was not rotated to the correct orientation
When re-choosing an image or a video in multi-selection mode, the asset was unnecessarily re-centered. Now, we only re-center the asset if we don't have a stored crop position for this asset.
iirovi-rs
requested review from
zeph-cohen10,
aylwing-rewardstyle and
MikkoKuivanenRS
MikkoKuivanenRS
approved these changes
Mar 13, 2024
zeph-cohen10
approved these changes
Mar 13, 2024
iirovi-rs
force-pushed
the
fix/image-centering-and-cropping
branch
from
2306f05
to
bbbc0c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains four separate fixes: