Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply refactor to gcp.py #43

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Apply refactor to gcp.py #43

merged 1 commit into from
Dec 11, 2023

Conversation

nweires
Copy link
Collaborator

@nweires nweires commented Dec 11, 2023

Apply the refactoring from NREL#422 to gcp.py.

Tested by doing a test run.

Also includes a couple fixes that are in NREL#424.

Copy link

File Coverage
All files 86%
base.py 90%
exc.py 57%
hpc.py 78%
local.py 70%
postprocessing.py 83%
utils.py 91%
cloud/docker_base.py 89%
sampler/base.py 79%
sampler/downselect.py 33%
sampler/precomputed.py 93%
sampler/residential_quota.py 61%
test/shared_testing_stuff.py 85%
test/test_docker.py 33%
test/test_validation.py 97%
workflow_generator/base.py 90%
workflow_generator/commercial.py 53%
workflow_generator/residential_hpxml.py 86%

Minimum allowed coverage is 33%

Generated by 🐒 cobertura-action against b1b3d42

@nweires nweires requested a review from lathanh December 11, 2023 15:58
@nweires nweires merged commit 10426a4 into gcp Dec 11, 2023
6 of 7 checks passed
@nweires nweires deleted the natalie/refactor_gcp branch December 11, 2023 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants