Parser error improvements #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 1, 2014 15:20
-> `filename:line:column: reason`
Allows users to more easily reformat error messages.
|
I'm 👍 on this, @necolas any opinion? |
|
sgtm too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the following changes to parser errors:
1. Message format
Switch to a gnu-style format for parser error messages.*
This makes it easier to diagnose the location of an error when multiple CSS files are being parsed in a build chain. There are also terminals and other tools that can parse messages formatted this way and jump to the location of the error in a text editor/IDE.
* Note: if there's a different format that you would prefer that also includes the filename, I'd be happy to change it. I picked this format because it's fairly common.
2. Capture "reason"
Add the raw error message generated by the parser without filename/line/column, stored as
reasonon the Error object. This will make it easier to reformat parser error messages by consuming applications, if desired.