Normalize test cases #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
From what I could see, it looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This unifies the parser and stringifier test cases as discussed in #34. It also cleans up the test files and makes them all use should.js instead of a mix of should.js and assert. All dev dependencies now have version specified (the new should.js is much faster than the older version and speeds up the tests noticeably).
While working with the dev dependencies I also noticed that
inheritsshould be moved to regular dependencies instead of dev dependencies, sincelib/stringify/compress.jsrequires it.This is a big PR, but really should be reviewed thoroughly since it moves the tests around quite a bit (ping @necolas @jonathanong).