New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1 plugin changes #148
v1 plugin changes #148
Conversation
OK, the major part of this is done. All plugins have been extracted into their own repos (linked above) and all of those new repos are building successfully on Travis. There are only 3 remaining tests in rework proper. :) Can somebody give this a once over? Also, what is the status of parse and stringify? Any ETA on moving them to v2 and Rework to v1? @reworkcss/owners |
we can just remove any deprecation warnings for v1 like https://github.com/reworkcss/rework/blob/v1/lib/rework.js#L65. i also prefer to depend on |
Good catches, both fixed. |
nice one! |
sweet, good stuff, we should squash the commits before merge |
What's the ETA on merging this? I have a pull request on the |
@artnez Waiting on v2 of css-parse and css-stringify afaik, but not sure what the status of those is. |
Why do we need to wait on new versions of css-parse and css-stringify before merging this in? |
@necolas I don't think we need to wait for merging this, but we should probably wait before releasing v1.0 |
Yeah |
This was applied in 7affb81 |
Thinking it will be easier to track a single PR rather than 10 separately.
Plugins removed: