Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1 plugin changes #148

Closed
wants to merge 29 commits into from
Closed

v1 plugin changes #148

wants to merge 29 commits into from

Conversation

bclinkinbeard
Copy link
Contributor

Thinking it will be easier to track a single PR rather than 10 separately.

Plugins removed:

@bclinkinbeard
Copy link
Contributor Author

OK, the major part of this is done. All plugins have been extracted into their own repos (linked above) and all of those new repos are building successfully on Travis. There are only 3 remaining tests in rework proper. :)

Can somebody give this a once over? Also, what is the status of parse and stringify? Any ETA on moving them to v2 and Rework to v1?

@reworkcss/owners

@jonathanong
Copy link
Contributor

we can just remove any deprecation warnings for v1 like https://github.com/reworkcss/rework/blob/v1/lib/rework.js#L65. i also prefer to depend on css-stringify and css-parse directly instead of through css, which is kind of annoying.

@bclinkinbeard
Copy link
Contributor Author

Good catches, both fixed.

@necolas
Copy link
Contributor

necolas commented Mar 17, 2014

nice one!

@tj
Copy link
Member

tj commented Mar 29, 2014

sweet, good stuff, we should squash the commits before merge

@artnez
Copy link
Contributor

artnez commented May 10, 2014

What's the ETA on merging this? I have a pull request on the at2x repo. Should I back-port it here? reworkcss/rework-plugin-at2x#2

@bclinkinbeard
Copy link
Contributor Author

@artnez Waiting on v2 of css-parse and css-stringify afaik, but not sure what the status of those is.

@necolas
Copy link
Contributor

necolas commented May 23, 2014

Why do we need to wait on new versions of css-parse and css-stringify before merging this in?

@conradz
Copy link
Contributor

conradz commented May 23, 2014

@necolas I don't think we need to wait for merging this, but we should probably wait before releasing v1.0

@necolas
Copy link
Contributor

necolas commented May 23, 2014

Yeah

bclinkinbeard added a commit that referenced this pull request May 23, 2014
bclinkinbeard added a commit that referenced this pull request May 23, 2014
@necolas
Copy link
Contributor

necolas commented May 24, 2014

This was applied in 7affb81

@necolas necolas closed this May 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants