Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏠[WiP] Organizational Features - Part 2 #1121

Merged
merged 6 commits into from
Jul 23, 2023
Merged

🏠[WiP] Organizational Features - Part 2 #1121

merged 6 commits into from
Jul 23, 2023

Conversation

awtkns
Copy link
Contributor

@awtkns awtkns commented Jul 23, 2023

No description provided.

@vercel
Copy link

vercel bot commented Jul 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agent-gpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 23, 2023 8:04pm

@ergomake
Copy link

ergomake bot commented Jul 23, 2023

Hi 👋

Here's a preview environment 🚀

https://next-reworkd-agentgpt-1121.env.ergomake.link

Environment Summary 📑

Container Source URL
next Dockerfile https://next-reworkd-agentgpt-1121.env.ergomake.link
platform Dockerfile https://platform-reworkd-agentgpt-1121.env.ergomake.link
db Dockerfile [not exposed - internal service]
weaviate semitechnologies/weaviate:1.19.6 https://weaviate-reworkd-agentgpt-1121.env.ergomake.link

Here are your environment's logs.

For questions or comments, join Discord.

Click here to disable Ergomake.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be called views?

@@ -18,25 +18,36 @@ def user_crud(


async def get_current_user(
x_organization_id: Annotated[str | None, Header()] = None,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the x_?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By convention, if a system wants to add its own custom header, it starts with X-. This is so they can be sure their custom headers don't accidentally take the name of any defined header, current or future.

@asim-shrestha
Copy link
Contributor

mypy failing

Comment on lines +36 to +45
<div className="relative">
{user && (
<img
className="h-9 w-9 rounded-md bg-neutral-800"
src={get_avatar(user)}
alt="user avatar"
/>
)}
{organization && <FaBuilding className="absolute -right-1 -top-1 text-white" />}
</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will have to update this in the future. I like how linear displays orgs

): Promise<z.infer<T>> => {
console.log("get", path, schema, accessToken, organizationId);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

Suggested change
console.log("get", path, schema, accessToken, organizationId);

@awtkns awtkns merged commit 8c77fdb into main Jul 23, 2023
9 checks passed
@awtkns awtkns deleted the orgs branch August 3, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants