Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐞 Platform bug squashing #1178

Merged
merged 11 commits into from
Aug 2, 2023
Merged

🐞 Platform bug squashing #1178

Changes from 6 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
2cba615
disable click to open blockdialog when showing createForm
shahrishabh7 Aug 2, 2023
95a6367
update
shahrishabh7 Aug 2, 2023
1550727
remove useeffect
shahrishabh7 Aug 2, 2023
29a91b1
remove useeffet
shahrishabh7 Aug 2, 2023
ce51810
remove space
shahrishabh7 Aug 2, 2023
cabf4d8
merged changes
shahrishabh7 Aug 2, 2023
6e77112
dont show workflows on plus button click
shahrishabh7 Aug 2, 2023
b040214
merge asim edits
shahrishabh7 Aug 2, 2023
f923d5a
handle pane double click
shahrishabh7 Aug 2, 2023
9884f89
remove prints from useworkflow
shahrishabh7 Aug 2, 2023
89cbae0
updated
shahrishabh7 Aug 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion next/src/pages/workflow/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,12 @@ const WorkflowPage: NextPage = () => {

const [open, setOpen] = useState(false);

const onPaneClick = () => {
if (!showCreateForm) {
shahrishabh7 marked this conversation as resolved.
Show resolved Hide resolved
setOpen(true);
}
};

const changeQueryParams = async (newParams: Record<string, string | undefined>) => {
let updatedParams = {
...router.query,
Expand Down Expand Up @@ -252,7 +258,7 @@ const WorkflowPage: NextPage = () => {
nodesModel={nodesModel}
edgesModel={edgesModel}
className="min-h-screen flex-1"
onPaneClick={() => setOpen(true)}
onPaneClick={onPaneClick}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed this to onPaneDoubleClick in a different commit, should be good to merge after fixing conflicts :)

/>
</>
);
Expand Down
Loading