Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Add Validation For Name & Goal #302

Merged
merged 3 commits into from Apr 21, 2023

Conversation

l2hyunwoo
Copy link
Contributor

fixed #288

@vercel
Copy link

vercel bot commented Apr 21, 2023

@l2hyunwoo is attempting to deploy a commit to the reworkd Team on Vercel.

A member of the Team first needs to authorize it.

@@ -0,0 +1,16 @@
import { isEmptyOrBlank } from "../src/utils/whitespace";

describe("WhiteSpace and empty string should return true", () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice to add tests!

@vercel
Copy link

vercel bot commented Apr 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agent-gpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 21, 2023 4:47pm

@l2hyunwoo
Copy link
Contributor Author

nice to add tests!

Thanks!

@awtkns
Copy link
Contributor

awtkns commented Apr 21, 2023

@l2hyunwoo looks good! Tried out the preview, users can still make tasks / goals with whitespace at the start or end eg: mygoal. We will probably need to trim the string before saving. This can be a folllow up though :)

@awtkns awtkns merged commit f730c66 into reworkd:main Apr 21, 2023
3 checks passed
@l2hyunwoo
Copy link
Contributor Author

@awtkns ok, I'll keep it through.

@l2hyunwoo l2hyunwoo deleted the feature/fix-validation-empty-name-goal branch April 21, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Missing Validation - Empty Name / Goal allowed
2 participants