Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Dockerfile and entrypoint.sh to handle Windows line endings #514

Merged
merged 1 commit into from May 11, 2023
Merged

Fixed Dockerfile and entrypoint.sh to handle Windows line endings #514

merged 1 commit into from May 11, 2023

Conversation

lauralex
Copy link
Contributor

@lauralex lauralex commented May 11, 2023

The ./next:/next/ volume binding in the docker-compose.yml file was overwriting the DOS2UNIX fix done at the image build stage. Now, the entrypoint.sh is moved to the / directory to avoid the volume binding (causing the line ending overwrite).

Also, the dos2unix fix is run in the entrypoint.sh to fix the wait-for-db.sh and .env files at runtime (for the same reason).

closes #511

@vercel
Copy link

vercel bot commented May 11, 2023

@lauralex is attempting to deploy a commit to the reworkd Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented May 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agentgpt-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 11, 2023 5:07pm

@vercel vercel bot temporarily deployed to Preview – agentgpt-docs May 11, 2023 15:59 Inactive
@lauralex lauralex marked this pull request as draft May 11, 2023 16:17
Signed-off-by: Alessandro Bellia <casilda.bell85@gmail.com>
@lauralex lauralex marked this pull request as ready for review May 11, 2023 17:07
@lauralex
Copy link
Contributor Author

Tested and working

@vercel vercel bot temporarily deployed to Preview – agentgpt-docs May 11, 2023 17:07 Inactive
@asim-shrestha asim-shrestha merged commit d44099e into reworkd:main May 11, 2023
2 of 3 checks passed
@lauralex lauralex deleted the fix/Windows_line_ending_fix branch May 11, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docker setup error
2 participants