🐛 Use parametrize instead of creating replicated test functions #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@hibestil is attempting to deploy a commit to the reworkd Team on Vercel. A member of the Team first needs to authorize it. |
platform/reworkd_platform/tests/agent/agent/remove_task_prefix_test.py
Outdated
Show resolved
Hide resolved
asim-shrestha
approved these changes
May 25, 2023
|
Awesome! Yeah our tests are quite lacking. Would love to make them better if you're interested Looks good to merge, just has the one comment |
|
@asim-shrestha I've made some changes according to your comments. Fyi. |
Merged
|
Thanks @hibestil, we're going to be adding more tickets Reach out if there's anything you want to tackle / need help with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed there are recurring tests that can be collected within one parametrized test function. Using parameterized for them would be beneficial for creating a clean test environment.