Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dockerfile + missing env vars in example #853

Merged
merged 3 commits into from Jun 27, 2023

Conversation

tim-codes
Copy link
Contributor

Just finished configuring the project locally and had to make a few corrections to get it working:

  1. Platform Dockerfile was failing for missing pkg-config dependency
  2. .env file required 2 more max-loops vars to startup properly

@vercel
Copy link

vercel bot commented Jun 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agent-gpt 🔄 Building (Inspect) Jun 27, 2023 4:02pm
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 27, 2023 4:02pm

@vercel
Copy link

vercel bot commented Jun 23, 2023

@tim-codes is attempting to deploy a commit to the reworkd Team on Vercel.

A member of the Team first needs to authorize it.

@vercel vercel bot temporarily deployed to Preview – docs June 23, 2023 10:59 Inactive
@asim-shrestha
Copy link
Contributor

Thanks! Lets do the following instead

REWORKD_PLATFORM_MAX_LOOPS=${NEXT_PUBLIC_MAX_LOOPS}

Also note, if you run the setup commands (./setup.sh for mac) It should tell you when you have an out of date ENV value

@asim-shrestha
Copy link
Contributor

Checking in @tim-codes :)

@tim-codes
Copy link
Contributor Author

Hey @asim-shrestha thanks will update today :)

… hardcoding the value in REWORKD_PLATFORM_MAX_LOOPS to improve maintainability and consistency
@vercel vercel bot temporarily deployed to Preview – docs June 27, 2023 16:02 Inactive
@tim-codes
Copy link
Contributor Author

@asim-shrestha changes made. FYI I did do the setup.sh script originally, but still needed the env var amendments.

@asim-shrestha
Copy link
Contributor

Thank you @tim-codes!

@asim-shrestha asim-shrestha merged commit ffba291 into reworkd:main Jun 27, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants