Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👟 Footer for landing page #940

Merged
merged 3 commits into from Jul 3, 2023
Merged

👟 Footer for landing page #940

merged 3 commits into from Jul 3, 2023

Conversation

awtkns
Copy link
Contributor

@awtkns awtkns commented Jul 3, 2023

relates to #938

Text alignment isn't quite perfect but this can be addressed later

@vercel
Copy link

vercel bot commented Jul 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agent-gpt ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2023 3:19am
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2023 3:19am

@ergomake
Copy link

ergomake bot commented Jul 3, 2023

Hi 👋

Here's a preview environment 🚀

https://next-reworkd-agentgpt-940.env.ergomake.link

Environment Summary 📑

Container Source URL
next Dockerfile https://next-reworkd-agentgpt-940.env.ergomake.link
docs Dockerfile https://docs-reworkd-agentgpt-940.env.ergomake.link
platform Dockerfile https://platform-reworkd-agentgpt-940.env.ergomake.link
db Dockerfile [not exposed - internal service]
weaviate semitechnologies/weaviate:1.19.6 https://weaviate-reworkd-agentgpt-940.env.ergomake.link

Questions? Comments? Suggestions? Join Discord.

Click here to disable Ergomake.

@vercel vercel bot temporarily deployed to Preview – docs July 3, 2023 03:06 Inactive
Comment on lines +10 to +31
const links = [
{
name: "Github",
href: "https://github.com/reworkd/AgentGPT",
icon: FaGithub,
},
{
name: "Twitter",
href: "https://twitter.com/ReworkdAI",
icon: FaTwitter,
},
{
name: "Discord",
href: "https://discord.gg/gcmNyAAFfV",
icon: FaDiscord,
},
{
name: "LinkedIn",
href: "https://www.linkedin.com/company/reworkd/",
icon: FaLinkedin,
},
];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

links.tsx has this. Lets reuse that - we can also add the LinkedIn link there

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw that but I want to use the IconType not the component here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally links.tsx should use the icontype aswell. but that can be future

Comment on lines +65 to +78
<div className="hidden flex-row gap-3 text-white sm:flex">
{links.map((link, i) => (
<a
key={i}
href={link.href}
target="_blank"
rel="noopener noreferrer"
className="transition-all hover:rotate-6 hover:text-purple-400"
>
<span className="sr-only">{link.name}</span>
<link.icon size={24} />
</a>
))}
</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this one for? Its just always hidden?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is shows up on large screens, notice the sm:flex

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah mb, but we could just add selector styling for the gap and do just two link icons instead of doing two of the entire thing?

Comment on lines +43 to +48
<a className="text-center" href="https://reworkd.ai/privacyPolicy" target="_blank">
Privacy Policy
</a>
<a className="text-center" href="http://reworkd.ai/terms">
Terms and Conditions
</a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could also place these in the links section. Also, one of these is missing a target="_blank"

@asim-shrestha
Copy link
Contributor

image

On mobile:

  • Icons are too large
  • Logo / text should be centered
  • Privacy policy text, etc button text should be larger

In general:

  • Privacy policy text, etc button text should have a hover highlight

Co-authored-by: Asim Shrestha <50181239+asim-shrestha@users.noreply.github.com>
@awtkns awtkns merged commit eec13e6 into main Jul 3, 2023
4 of 6 checks passed
@vercel vercel bot temporarily deployed to Preview – docs July 3, 2023 03:19 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants