Fix shebang so shell scripts work on more systems #955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In general, `#!/usr/bin/env bash` is considered better practice because it's more portable. Bash is not always located at /bin/bash. This will make the scripts work on systems, like NixOS
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@MichaelBergquistSuarez is attempting to deploy a commit to the reworkd Team on Vercel. A member of the Team first needs to authorize it. |
|
Hi 👋 Here's a preview environment 🚀 https://next-reworkd-agentgpt-955.env.ergomake.link Environment Summary 📑
Questions? Comments? Suggestions? Join Discord. Click here to disable Ergomake. |
|
Thanks @MichaelBergquistSuarez! |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In general,
#!/usr/bin/env bashis considered better practice because it's more portable.Bash is not always located at /bin/bash.
This will make the scripts work on systems, like the Linux dist NixOS
Motivation and Context
The readme instructions does not work on some systems. Like mine (NixOS).
How has this been tested?
By running
./setup.shas mentioned abovein
Types of changes
Changes visible to users:
fix- non-breaking change which fixes an issue)feat- non-breaking change which adds functionality)feat!!orfix!!- fix or feature that would cause existing functionality to not work as expected)docs- improvements to any documentation content for users)page- improvements to the Homepage #{HOMEPAGE} should lead to the place where one could actually change the homepagecontrib- any improvements to documentation content for contributors - see ContributingInternal changes:
refactor- non-breaking change which only improves the design or structure of existing code, and making no changes to its external behaviour)test- additions and improvements to unit tests and the smoke tests)chore- examples include GitHub Actions, issue templates)Checklist
npm run lint.Terms