馃殌 Remove Annotations and Tag All text elements (optionally) #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarsier/core.py
Outdated
| @@ -16,14 +16,15 @@ def __init__(self, ocr_service: OCRService): | |||
| with open(self._JS_TAG_UTILS, "r") as f: | |||
| self._js_utils = f.read() | |||
|
|
|||
| async def page_to_image(self, driver: AnyDriver) -> Tuple[bytes, Dict[int, str]]: | |||
| async def page_to_image(self, driver: AnyDriver, tagUninteractableText: bool = False) -> Tuple[bytes, Dict[int, str]]: | |||
There was a problem hiding this comment.
Suggested change
| async def page_to_image(self, driver: AnyDriver, tagUninteractableText: bool = False) -> Tuple[bytes, Dict[int, str]]: | |
| async def page_to_image(self, driver: AnyDriver, tag_text_elements: bool = False) -> Tuple[bytes, Dict[int, str]]: |
tarsier/core.py
Outdated
| return {int(key): value for key, value in tag_to_xpath.items()} | ||
|
|
||
| async def _remove_tags(self, adapter: BrowserAdapter) -> None: | ||
| # await adapter.run_js(self._js_utils) |
There was a problem hiding this comment.
Why? We call this after tagging the page
There was a problem hiding this comment.
Oh do you mean the comment? Yes I think we could鈥攕ince it's private and only ever called after running _tag_page, the utils should alr be loaded
There was a problem hiding this comment.
Yeah just the comment
tarsier/core.py
Outdated
Comment on lines
66
to
69
| script = "removeTags();" | ||
| if isinstance(adapter, SeleniumAdapter): | ||
| script = f"return window.{script}" | ||
|
|
There was a problem hiding this comment.
Abstractions shouldn't leak like this. Could make a call_method function or something in driver. Could also just pass in JS code directly to run
There was a problem hiding this comment.
Hm yeah, true. Thoughts @awtkns?
|
Run black 猬涳笍 |
|
LGTM! |
awtkns
commented
Nov 14, 2023
asim-shrestha
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bonus: Since we are now annotating using spans we can now add CSS to the annotations so that vision model can see them easier
fixes #5 #7