Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🆑 Make spans have red background with white text #9

Merged
merged 5 commits into from
Nov 15, 2023
Merged

🆑 Make spans have red background with white text #9

merged 5 commits into from
Nov 15, 2023

Conversation

awtkns
Copy link
Contributor

@awtkns awtkns commented Nov 15, 2023

Screenshot 2023-11-14 at 6 04 21 PM

  • spans now have a red background with white text (better for gpt4v)
  • refactored js_utils
  • converted to typescript
  • utils can be rebuild with npm run build
  • we ship the build js :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prettier format

const elIsClean = (el: HTMLElement) => {
if (el.style && el.style.display === "none") return false;
if (el.hidden) return false;
// @ts-ignore
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is HTMLElement the right type here then?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

theres a lot of them, didnt want to deal with it rn

@awtkns awtkns merged commit ae5a749 into main Nov 15, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants