Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure to check testing git repository #1595

Closed
ferki opened this issue Jun 9, 2023 · 0 comments · Fixed by #1596
Closed

Failure to check testing git repository #1595

ferki opened this issue Jun 9, 2023 · 0 comments · Fixed by #1596
Labels
bug Confirmed bugs

Comments

@ferki
Copy link
Member

ferki commented Jun 9, 2023

Describe the bug

Similarly to #1589, checking the git repository used for testing purposes fails for ancient versions of git when git -C is used instead of cd-ing into the directory.

See for example: http://www.cpantesters.org/cpan/report/5056406c-010c-11ee-a26f-43e86d8775ea

Expected behavior

t/scm/git. should either pass, or back off gracefully.

How to reproduce it

Run t/scm/git.t tests on a git version old enough without -C support (like older than 1.8.5).

Code example

No code example.

Additional context

Apparently I overlooked that single remaining instance of git -C call on my previous fix attempt.

Rex version

1.14.2.1

Perl version

5.24.0

Operating system running rex

Debian Wheezy

Operating system managed by rex

local

How rex was installed?

cpan client

@ferki ferki added the bug Confirmed bugs label Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant