Merge pull request #13 from willyboy/master

Fix connectionCount
rexxars · Dec 11, 2016 · 9300f58 · 9300f58
2 parents aa40300 + 69ff5ef
commit 9300f58
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/lib/sse-channel.js b/lib/sse-channel.js
@@ -108,7 +108,9 @@ SseChannel.prototype.addClient = function(req, res, callback) {
 
     // Add the connection to our pool
     this.connections.push(res);
-    this.connectionCount++;
+    //It would be preferable to not expose this.connectionCount at all and force users to use getConnectionCount
+    //However, this PR should be backwards compatible. Maybe add a deprecation message?
+    this.connectionCount = this.connections.length;
 
     // When the client disconnects, remove the client
     var removeClient = this.removeClient.bind(this, res);
@@ -144,7 +146,7 @@ SseChannel.prototype.addClient = function(req, res, callback) {
  */
 SseChannel.prototype.removeClient = function(res) {
     pull(this.connections, res);
-    this.connectionCount--;
+    this.connectionCount = this.connections.length;
 
     this.emit('disconnect', this, res);
 };
@@ -155,7 +157,7 @@ SseChannel.prototype.removeClient = function(res) {
  * @return {Number} Number of active connections
  */
 SseChannel.prototype.getConnectionCount = function() {
-    return this.connectionCount;
+    return this.connections.length;
 };
 
 /**