Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default UTF-8 encoding #14

Merged
merged 2 commits into from
Feb 10, 2017
Merged

Default UTF-8 encoding #14

merged 2 commits into from
Feb 10, 2017

Commits on Feb 9, 2017

  1. Merge pull request #1 from rexxars/master 

    keeping in sync
    @willyboy
    willyboy committed Feb 9, 2017
    Configuration menu
    Copy the full SHA
    b9a814f View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2017

  1. Force default content to utf 8 

    UTF-8 Encoding is required for event streams per spec (https://developer.mozilla.org/en-US/docs/Web/API/Server-sent_events/Using_server-sent_events). However, if you're running node behind a Tomcat server, the default content is set to iso-8859-1. This will throw an error in Chrome. Since UTF-8 is required, I think setting it should be part of the library.
    @willyboy
    willyboy committed Feb 10, 2017
    Configuration menu
    Copy the full SHA
    af93bf1 View commit details
    Browse the repository at this point in the history