Make day parser more generalizable to complex combinations of days and day ranges #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rezemika
requested changes
Apr 1, 2018
| @@ -22,10 +22,10 @@ def digital_moment(self, arg): | |||
| else: | |||
| time = datetime.datetime.strptime(arg[0], "%H:%M").time() | |||
| return Moment(MomentKind.NORMAL, time=time) | |||
|
|
|||
There was a problem hiding this comment.
I know this is a common convention, but just to remain consistent and atomic, I think unindentation of blank lines should be done later, in another PR.
|
Ping @nbolten. ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
humanized_opening_hourscurrently fails when parsing day fields that have a single day and then a day range, e.g.Mo, We-Fr 10:00-17:00. This pull request is a starting point for fixing this issue, but should be taken with a grain of salt since I'm new to EBNF.