Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken tests on MacOS 12 (Monterey) Apple Silicon M1 Max #623

Closed
slonik-az opened this issue Dec 6, 2021 · 2 comments
Closed

Broken tests on MacOS 12 (Monterey) Apple Silicon M1 Max #623

slonik-az opened this issue Dec 6, 2021 · 2 comments

Comments

@slonik-az
Copy link

Hi,
I am compiling gocryptfs on latest MacBook Pro M1 Max (2021) running MacOS 12.0.1 Monterey, using Xcode-13, go-1.17.3 and macFUSE-4.2.3.

Compiling latest master (hash=39e736c...) with

$ ./build-without-openssl.bash

completes OK and without errors.

However running tests fails with errorcode 2:

$ ./test-without-openssl.bash

Using TMPDIR=/var/folders/XX/XXXXXXXXXXXXXXXXXXXXXXXXXX/T/
flock is not available, skipping
gocryptfs v2.2.1-8-g39e736c without_openssl; go-fuse v2.1.1-0.20210825171523-3ab5d95a30ae; 2021-12-05 go1.17.3 darwin/arm64
go: downloading github.com/pkg/xattr v0.4.3
# github.com/rfjakob/gocryptfs/v2/contrib/getdents-debug/getdents
vet: contrib/getdents-debug/getdents/getdents.go:74:19: Getdents not declared by package unix
# github.com/rfjakob/gocryptfs/v2/tests/cli
vet: tests/cli/cli_test.go:985:24: Creat not declared by package syscall
# github.com/rfjakob/gocryptfs/v2/tests/defaults
vet: tests/defaults/main_test.go:404:25: Creat not declared by package syscall
# github.com/rfjakob/gocryptfs/v2/tests/plaintextnames
vet: tests/plaintextnames/plaintextnames_test.go:119:22: Creat not declared by package syscall
# github.com/rfjakob/gocryptfs/v2/tests/sharedstorage
vet: tests/sharedstorage/sharedstorage_test.go:80:21: Creat not declared by package unix
# github.com/rfjakob/gocryptfs/v2/tests/matrix
vet: tests/matrix/concurrency_test.go:147:23: Creat not declared by package syscall
# github.com/rfjakob/gocryptfs/v2/tests/root_test_test
vet: tests/root_test/root_test.go:67:13: Setresuid not declared by package unix

Is it something to be expected or it needs fixing?

rfjakob added a commit that referenced this issue Dec 8, 2021
Creat() is equivalent to Open(..., O_CREAT|O_WRONLY|O_TRUNC, ...)
and MacOS does not have syscall.Creat().

#623
@rfjakob rfjakob closed this as completed in a48d6c3 Dec 8, 2021
@rfjakob
Copy link
Owner

rfjakob commented Dec 8, 2021

No, these were bugs! Thanks for the report!

@slonik-az
Copy link
Author

slonik-az commented Dec 8, 2021

Thanks for fixing the test breakage problem. Now I am able to run the tests. Unfortunately, quite a few of them fail, see the test log attached.

test.log

Also, the test script failed to unmount the test directories and left behind a mess in the mount table. I have to reboot to clean them up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants