disable new filename encryption (diriv)

[diseq]

can you make it possible to disable the new (diriv) filename encryption for mounts (like it was before)

as far as i can tell it cannot be turned off any more. (like in mkdir)

func (fs *FS) Mkdir(relPath string, mode uint32, context *fuse.Context) (code fuse.Status) {
    if fs.isFiltered(relPath) {
        return fuse.EPERM
    }
    encPath, err := fs.getBackingPath(relPath)
    if err != nil {
        return fuse.ToStatus(err)
    }
    // The new directory may take the place of an older one that is still in the cache
    fs.CryptFS.DirIVCacheEnc.Clear()
    // Create directory
    fs.dirIVLock.Lock()
    defer fs.dirIVLock.Unlock()
    err = os.Mkdir(encPath, os.FileMode(mode))
    if err != nil {
        return fuse.ToStatus(err)
    }
    // Create gocryptfs.diriv inside
    err = cryptfs.WriteDirIV(encPath)
    if err != nil {
        // This should not happen
        cryptfs.Warn.Printf("Creating %s in dir %s failed: %v\n", cryptfs.DIRIV_FILENAME, encPath, err)
        err2 := syscall.Rmdir(encPath)
        if err2 != nil {
            cryptfs.Warn.Printf("Mkdir: Rollback failed: %v\n", err2)
        }
        return fuse.ToStatus(err)
    }
    return fuse.OK
}

[diseq]

seems to create always gocryptfs.diriv.
even with featureset diriv not set.

[rfjakob]

Oh dear, I need to add testcases for -plaintextnames.

For now, does the latest change fix the issue for you?

[diseq]

thanks a lot. looks great!
i'll try that tomorrow.

hey. btw. greetings from vienna to vienna.

[rfjakob]

:)

[rfjakob]

Testcases added, this bug should be gone for good.